Ensure persisted zeto state and nullifiers are all 32 bytes #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #410
The problem was that when the nullifiers were generated and persisted in
state_nullifiers
, they were padded to 32 bytes (because they are big numbers, they can be less than 32 bytes), but in the processing of the events for spent states, the nullifiers were NOT padded. This is not a problem when most of the time the big number from the Poseidon hash ends up being 32 bytes, but is a problem when the hash is less than 32 bytes, as it causes the mismatch when comparing the nullifier ID vs. the spend ID.The fix is to always pad the state IDs, for both states and nullifiers when processing events